Make release status configurable #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new attribute, 'release_status', and a new role, D::Z::R::ReleaseStatusProvider. The 'is_trial' variable is changed to be read-only. This will break the handful of CPAN modules that try to set it. Those modules should set the RELEASE_STATUS environment variable before building instead. For backwards compatibility, 'is_trial' in dist.ini and the TRIAL environment variable are supported.
|
I still need to send patches to the affected distributions, so please |
dagolden
pushed a commit
to dagolden/Dist-Zilla-Plugin-TrialVersionComment
that referenced
this pull request
Mar 29, 2015
is_trial is likely to become read-only as a part of rjbs/Dist-Zilla#438 which adds support for customizing release status
dagolden
pushed a commit
to dagolden/p5-dist-zilla-plugin-run
that referenced
this pull request
Mar 29, 2015
is_trial is likely to become read-only as a part of rjbs/Dist-Zilla#438 which adds support for customizing release status
dagolden
pushed a commit
to dagolden/Dist-Zilla-App-Command-update
that referenced
this pull request
Mar 30, 2015
is_trial is likely to become read-only as a part of rjbs/Dist-Zilla#438 which adds support for customizing release status
|
OK. All dists that I could find via grep.cpan.me have pull requests, so I think this is ready to go once you've reviewed it. |
|
If there is any runtime code affected, could |
|
@karenetheridge, done |
dagolden
force-pushed
the
configurable-release-status
branch
from
710cca4 to
d0d961c
Compare
tsibley
added a commit
to tsibley/Dist-Zilla-App-Command-update
that referenced
this pull request
Apr 1, 2015
As David Golden pointed out in PR #2, is_trial is likely to become read-only as a part of rjbs/Dist-Zilla#438 which adds support for customizing release status. Using TRIAL maintains maximum compatibility with current versions of dzil as well as future versions.
|
::update 0.05, just released, ensures compat with this PR. |
|
Thanks, 5.035 released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new attribute, 'release_status', and a new
role, D::Z::R::ReleaseStatusProvider.
The 'is_trial' variable is changed to be read-only. This will break the
handful of CPAN modules that try to set it. Those modules should set
the RELEASE_STATUS environment variable before building instead.
For backwards compatibility, 'is_trial' in dist.ini and the TRIAL
environment variable are supported.